[ 
https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059082#comment-15059082
 ] 

Li Lu commented on YARN-4224:
-----------------------------

Thanks [~varun_saxena]! The plan on the query parameters looks fine to me now. 
We can firstly focus on the end points in this JIRA, then move to detailed 
query parameter design in future. With regard to the new end points, a few 
feedbacks:
bq. this pretty much makes us get the entities in a hierarchical fashion i.e. 
first get flows, then runs, then apps, and then generic entities. Because we 
want server to decide the delimiter instead of us fixing it.
Yes and no. For flows and flow runs, yes because a flow's name and sequence 
number is not globally unique. When discussing flows and flow runs, we have to 
put them in a context with cluster and user information. However, for 
applications, its app id is globally unique (it has a cluster timestamp and an 
id). Therefore, for applications, other than accessing through the hierarchical 
cluster, user, flow, flowrun order, we can directly access applications through 
/apps/appid. This will also help us to integrate with other YARN components. 
The key difference here is that, for YARN applications, their app id is 
actually an UID. 

bq. So we can have endpoints for entities as 
/entities/[entity_type]/[entities_UID] where UID is the UID we got from app 
response.
If there is an UID for each entity, why do we need to add entity type as one 
more layer of ID? If we'd like to query YARN_CONTAINER entities for a given 
application, maybe we'd prefer to support this in a query like: 
"/entities?type=YARN_CONTAINER&appid=my_app_id"? 

> Change the ATSv2 reader side REST interface to conform to current REST APIs' 
> in YARN
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-4224
>                 URL: https://issues.apache.org/jira/browse/YARN-4224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4224-YARN-2928.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to