[ 
https://issues.apache.org/jira/browse/YARN-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068535#comment-15068535
 ] 

Sunil G commented on YARN-4098:
-------------------------------

Hi [~rohithsharma]
Thank you for sharing the patch.

Some minor nits.
CS Page:
1. 
{noformat}
Higher the integer higher the priority of an applications. Note : Application 
priority is supported only for FIFO ordering policy.
{noformat}
Could we rephrase this as {{Higher integer value indicates higher priority for 
the application. Currently Application priority is supported only for FIFO 
ordering policy.}}

2. {{Application priority works along with FIFO ordering policy only}} can be 
{{Application priority works *only* along with FIFO ordering policy}}
3. {{Default priority for an applications can be at cluster level and queue 
level.}} its better to mention as {{an application}}.
4. Missing */* in {{etc/hadoop/capacity-scheduler.xml}}
5. typo in 
{{yarn.scheduler.capacity.root.<leaf-queue-patch>.default-application-priority}}.
 it can be {{<leaf-queue-path>}}

> Document ApplicationPriority feature
> ------------------------------------
>
>                 Key: YARN-4098
>                 URL: https://issues.apache.org/jira/browse/YARN-4098
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4098.patch, 0001-YARN-4098.patch, YARN-4098.rar
>
>
> This JIRA is to track documentation of application priority and its user, 
> admin and REST interfaces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to