[ 
https://issues.apache.org/jira/browse/YARN-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068959#comment-15068959
 ] 

Tianyin Xu commented on YARN-4482:
----------------------------------

I got some time to look into this. 
Yes... the values changed... (that's why the values are commented...)

The default of {{yarn.client.failover-max-attempts}} becomes {{-1}}, while the 
defaults of {{yarn.client.failover-sleep-base-ms}} and 
{{yarn.client.failover-sleep-max-ms}} are equivalent to the default value of 
{{yarn.resourcemanager.connect.retry-interval.ms}} (which is {{30000}} 
currently). 

The code is in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java

{code:title=RMProxy.java|borderStyle=solid}
177     long rmConnectionRetryIntervalMS =
178         conf.getLong(
179             YarnConfiguration.RESOURCEMANAGER_CONNECT_RETRY_INTERVAL_MS,
180             YarnConfiguration
181                 .DEFAULT_RESOURCEMANAGER_CONNECT_RETRY_INTERVAL_MS);
......
203       final long failoverSleepBaseMs = conf.getLong(
204           YarnConfiguration.CLIENT_FAILOVER_SLEEPTIME_BASE_MS,
205           rmConnectionRetryIntervalMS);
206 
207       final long failoverSleepMaxMs = conf.getLong(
208           YarnConfiguration.CLIENT_FAILOVER_SLEEPTIME_MAX_MS,
209           rmConnectionRetryIntervalMS);
210 
211       int maxFailoverAttempts = conf.getInt(
212           YarnConfiguration.CLIENT_FAILOVER_MAX_ATTEMPTS, -1);
{code}

The information should be updated in the docs.


> Default values of several config parameters are missing 
> --------------------------------------------------------
>
>                 Key: YARN-4482
>                 URL: https://issues.apache.org/jira/browse/YARN-4482
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.6.2, 2.6.3
>            Reporter: Tianyin Xu
>            Assignee: Mohammad Shahid Khan
>            Priority: Minor
>
> In {{yarn-default.xml}}, the default values of the following parameters are 
> commented out, 
> {{yarn.client.failover-max-attempts}}
> {{yarn.client.failover-sleep-base-ms}}
> {{yarn.client.failover-sleep-max-ms}}
> Are these default values changed (I suppose so)? If so, we should update the 
> new ones in {{yarn-default.xml}}. Right now, I don't know the real "default" 
> values...
> (yarn-default.xml)
> https://hadoop.apache.org/docs/r2.6.2/hadoop-yarn/hadoop-yarn-common/yarn-default.xml
> https://hadoop.apache.org/docs/r2.6.3/hadoop-yarn/hadoop-yarn-common/yarn-default.xml
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to