[
https://issues.apache.org/jira/browse/YARN-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073076#comment-15073076
]
Wangda Tan commented on YARN-4519:
----------------------------------
bq. I also think that it is necessary to move the logic of creating
normalizedDecreaseRequests (i.e. SchedContainerChangeRequest) into the
decreaseContainer() call (under the scope of CS lock), otherwise there would be
race condition when creating the delta resources. What do you think?
It seems to me that race could only happens when computing delta resource,
correct? If so, can we set delta resource of SchedContainerChangeRequest when
we enter decreaseContainer?
And also, updateIncreaseRequests could have same race condition, does it?
> potential deadlock of CapacityScheduler between decrease container and assign
> containers
> ----------------------------------------------------------------------------------------
>
> Key: YARN-4519
> URL: https://issues.apache.org/jira/browse/YARN-4519
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacityscheduler
> Reporter: sandflee
>
> In CapacityScheduler.allocate() , first get FiCaSchedulerApp sync lock, and
> may be get CapacityScheduler's sync lock in decreaseContainer()
> In scheduler thread, first get CapacityScheduler's sync lock in
> allocateContainersToNode(), and may get FiCaSchedulerApp sync lock in
> FicaSchedulerApp.assignContainers().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
