[
https://issues.apache.org/jira/browse/YARN-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094327#comment-15094327
]
Naganarasimha G R commented on YARN-4565:
-----------------------------------------
Hi [~wangda],
Patch is generally fine with very small nits
* one Checkstyle issue is related to patch(Unused import ) .
* In *TestFairOrderingPolicy*
** {{MockNM nm1 = rm.registerNode("h1:1234", 10 * GB); // label = x}} i think
assigning to a variable is not required here
** {{OrderingPolicy policy = lq.getOrderingPolicy();}} we can use generics
(OrderingPolicy<FiCaSchedulerApp>) here to avoid warnings
** {{Assert.assertTrue(((FairOrderingPolicy)policy).getSizeBasedWeight());}}
similar to the above comment for FairOrderingPolicy
> When sizeBasedWeight enabled for FairOrderingPolicy in CapacityScheduler,
> Sometimes lead to situation where all queue resources consumed by AMs only
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4565
> URL: https://issues.apache.org/jira/browse/YARN-4565
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, capacityscheduler
> Affects Versions: 2.8.0
> Reporter: Karam Singh
> Assignee: Wangda Tan
> Attachments: YARN-4565.1.patch, YARN-4565.2.patch
>
>
> When sizeBasedWeight enabled for FairOrderingPolicy in CapacityScheduler,
> Sometimes lead to situation where all queue resources consumed by AMs only,
> So from users perpective it appears that all application in queue are stuck,
> whole queue capacity is comsumed by AMs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
