[ https://issues.apache.org/jira/browse/YARN-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097113#comment-15097113 ]
Eric Payne commented on YARN-4108: ---------------------------------- [~leftnoteasy], just a couple of quick things. {{YARN-4108.poc.2-WIP.patch}} doesn't build for me. I get the following error: {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-yarn-server-resourcemanager: Compilation failure: Compilation failure: [ERROR] /hadoop/source/current/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java:[138,8] org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler is not abstract and does not override abstract method getPreemptionManager() in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacitySchedulerContext [ERROR] /hadoop/source/current/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java:[1644,9] cannot find symbol [ERROR] symbol: method getPreemptionManager() [ERROR] location: class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler {code} I added {{CapacityScheduler#getPreemptionManager}}. I created a class variable {{preemptionManager}}, initialized it in {{initScheduler}}, and returned it in {{getPreemptionManager}}. Also, in the design doc ({{YARN-4108-design-doc-V3.pdf}}), in the section titled "A little bit of background", under the first bullet, the "Configured" values for the first level queues add up to 110, not 100, as I would expect since the root Configured value is 100. > CapacityScheduler: Improve preemption to preempt only those containers that > would satisfy the incoming request > -------------------------------------------------------------------------------------------------------------- > > Key: YARN-4108 > URL: https://issues.apache.org/jira/browse/YARN-4108 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-4108-design-doc-V3.pdf, > YARN-4108-design-doc-v1.pdf, YARN-4108-design-doc-v2.pdf, > YARN-4108.poc.1.patch, YARN-4108.poc.2-WIP.patch > > > This is sibling JIRA for YARN-2154. We should make sure container preemption > is more effective. > *Requirements:*: > 1) Can handle case of user-limit preemption > 2) Can handle case of resource placement requirements, such as: hard-locality > (I only want to use rack-1) / node-constraints (YARN-3409) / black-list (I > don't want to use rack1 and host\[1-3\]) > 3) Can handle preemption within a queue: cross user preemption (YARN-2113), > cross applicaiton preemption (such as priority-based (YARN-1963) / > fairness-based (YARN-3319)). -- This message was sent by Atlassian JIRA (v6.3.4#6332)