[ https://issues.apache.org/jira/browse/YARN-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097494#comment-15097494 ]
Rohith Sharma K S commented on YARN-4389: ----------------------------------------- One small nit : Currently if user sets amBlacklistingEnabled explicitly to false then latest patch is considering global configuration. I think this should not be the case. Thoughts? Just check with an if-else clause {code} if (null != submissionContext.getAMBlackListRequest()) { // Consider app-level configuration } else { // consider global configurations } {code} > "yarn.am.blacklisting.enabled" and > "yarn.am.blacklisting.disable-failure-threshold" should be app specific > rather than a setting for whole YARN cluster > ------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: YARN-4389 > URL: https://issues.apache.org/jira/browse/YARN-4389 > Project: Hadoop YARN > Issue Type: Bug > Components: applications > Reporter: Junping Du > Assignee: Sunil G > Priority: Critical > Attachments: 0001-YARN-4389.patch, 0002-YARN-4389.patch, > 0003-YARN-4389.patch, 0004-YARN-4389.patch, 0005-YARN-4389.patch, > 0006-YARN-4389.patch, 0007-YARN-4389.patch > > > "yarn.am.blacklisting.enabled" and > "yarn.am.blacklisting.disable-failure-threshold" should be application > specific rather than a setting in cluster level, or we should't maintain > amBlacklistingEnabled and blacklistDisableThreshold in per rmApp level. We > should allow each am to override this config, i.e. via submissionContext. -- This message was sent by Atlassian JIRA (v6.3.4#6332)