[ https://issues.apache.org/jira/browse/YARN-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139964#comment-15139964 ]
Subru Krishnan commented on YARN-2575: -------------------------------------- Thanks [~seanpo03] for the updated patch. It LGTM, just some feedback on *ClientRMService::checkReservationACLs*: * Let's use _ReservationId_ instead of _reservationCreatorName_ as the argument as the logic to determine the submitter is common * I feel it's better to separate the checks as the logic will be more explicit Can you run it in a single box and validate the patch. > Consider creating separate ACLs for Reservation create/update/delete/list ops > ----------------------------------------------------------------------------- > > Key: YARN-2575 > URL: https://issues.apache.org/jira/browse/YARN-2575 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler, fairscheduler, resourcemanager > Reporter: Subru Krishnan > Assignee: Sean Po > Attachments: YARN-2575.v1.patch, YARN-2575.v10.patch, > YARN-2575.v2.1.patch, YARN-2575.v2.patch, YARN-2575.v3.patch, > YARN-2575.v4.patch, YARN-2575.v5.patch, YARN-2575.v6.patch, > YARN-2575.v7.patch, YARN-2575.v8.patch, YARN-2575.v9.patch > > > YARN-1051 introduces the ReservationSystem and in the current implementation > anyone who can submit applications can also submit reservations. This JIRA is > to evaluate creating separate ACLs for Reservation create/update/delete ops. > Depends on YARN-4340 -- This message was sent by Atlassian JIRA (v6.3.4#6332)