[
https://issues.apache.org/jira/browse/YARN-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158549#comment-15158549
]
Li Lu commented on YARN-4680:
-----------------------------
LGTM. The logic of synchronization in this patch is nontrivial (especially the
RW lock part, which is a little bit counter-intuitive). We may want to revisit
or refactor the writer/flush logic afterwards, but so far this patch
effectively fixes the timer thread leaking problem. I'd +1 to let this patch to
go in. In the next steps, we may want to replace the timers with scheduled
thread pool executor and/or refactor the code a little bit to simplify the
synchronization logic.
Let's wait for about a day on this fix. If by then there's no objection I'll
commit it.
> TimerTasks leak in ATS V1.5 Writer
> ----------------------------------
>
> Key: YARN-4680
> URL: https://issues.apache.org/jira/browse/YARN-4680
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-4680.1.patch, YARN-4680.20160108.patch,
> YARN-4680.20160109.patch, YARN-4680.20160222.patch
>
>
> We have seen TimerTasks leak which could cause application server done (such
> as oozie server done due to too many active threads)
> Although we have fixed some potentially leak situations in upper application
> level, such as
> https://issues.apache.org/jira/browse/MAPREDUCE-6618
> https://issues.apache.org/jira/browse/MAPREDUCE-6621, we still can not
> guarantee that we fixed the issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
