[
https://issues.apache.org/jira/browse/YARN-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168565#comment-15168565
]
Jian He commented on YARN-4117:
-------------------------------
[~giovanni.fumarola], thanks for working on this, a few comments and questions :
1. could you add comments at the header of each test to explain what the test
is doing so that it can be understood more easily?
2. this test is based on timing, can we check that
AllocateResponse#getAMRMToken actually returns a different token than previous
one ?
{code}
for (int i = 0; i < 5; i++) {
client.allocate(request);
request.setResponseId(request.getResponseId() + 1);
// Time slot to be sure the RM renew the token
Thread.sleep(1500);
}
{code}
3. why are the changes in MiniYarnCluster needed ?
4. what is the purpose of testE2ETokenSwap?
> End to end unit test with mini YARN cluster for AMRMProxy Service
> -----------------------------------------------------------------
>
> Key: YARN-4117
> URL: https://issues.apache.org/jira/browse/YARN-4117
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager, resourcemanager
> Reporter: Kishore Chaliparambil
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-4117.v0.patch
>
>
> YARN-2884 introduces a proxy between AM and RM. This JIRA proposes an end to
> end unit test using mini YARN cluster to the AMRMProxy service. This test
> will validate register, allocate and finish application and token renewal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
