[ 
https://issues.apache.org/jira/browse/YARN-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172403#comment-15172403
 ] 

Wangda Tan commented on YARN-4634:
----------------------------------

Hi [~sunilg],

Thanks for updating, however, I will hesitate to add new state 
{{labelToQueueMappingAvailable}} to RMNodeLabelsManager and AbstractCSQueue 
needs to update that state as well.

I suggest to check show labels hierarchy only if:
- There's label other than DEFAULT_LABEL has >0 activeNMs.

And let's keep queues page as simple as possible.

You can check RMNodeLabelsManager#pullRMNodeLabelsInfo for details (And 
NodeLabelsPage as an example).

Thoughts?

> Scheduler UI/Metrics need to consider cases like non-queue label mappings
> -------------------------------------------------------------------------
>
>                 Key: YARN-4634
>                 URL: https://issues.apache.org/jira/browse/YARN-4634
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4634.patch, 0002-YARN-4634.patch
>
>
> Currently when label-queue mappings are not available, there are few 
> assumptions taken in UI and in metrics.
> In above case where labels are enabled and available in cluster but without 
> any queue mappings, UI displays queues under labels. This is not correct.
> Currently  labels enabled check and availability of labels are considered to 
> render scheduler UI. Henceforth we also need to check whether 
> - queue-mappings are available
> - nodes are mapped with labels with proper exclusivity flags on
> This ticket also will try to see the default configurations in queue when 
> labels are not mapped. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to