[jira] [Commented] (YARN-4814) ATS 1.5 timelineclient impl call flush after every event write

[Xuan Gong (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194161#comment-15194161
 ] 

Xuan Gong commented on YARN-4814:
---------------------------------

Looks like the flush happens in ObjectMapper#writeValue.
{code}
@Override
    public void writeValue(JsonGenerator jgen, Object value)
        throws IOException, JsonGenerationException, JsonMappingException
    {
        SerializationConfig config = copySerializationConfig();
        if (config.isEnabled(SerializationConfig.Feature.CLOSE_CLOSEABLE) && 
(value instanceof Closeable)) {
            _writeCloseableValue(jgen, value, config);
        } else {
            _serializerProvider.serializeValue(config, jgen, value, 
_serializerFactory);
            if 
(config.isEnabled(SerializationConfig.Feature.FLUSH_AFTER_WRITE_VALUE)) {
                jgen.flush();
            }
        }
    }
{code}

For the performance purpose, we already have the flush timer, so we do not need 
to flush every time.

> ATS 1.5 timelineclient impl call flush after every event write
> --------------------------------------------------------------
>
>                 Key: YARN-4814
>                 URL: https://issues.apache.org/jira/browse/YARN-4814
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>
> ATS 1.5 timelineclient impl call flush after every event write.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)