[ https://issues.apache.org/jira/browse/YARN-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199736#comment-15199736 ]
Eric Badger commented on YARN-4686: ----------------------------------- [~kasha] When HA is not enabled, the RM will be transitioned to active in the RM serviceStart method. So it is not necessary to transition it to active in the MiniYARNCluster serviceStart method. However, the transitionToActive method will not end up actually transitioning the RM again since it checks to make sure that it is not already active before proceeding. I believe that this makes the MiniYARNCluster start method a little bit cleaner since there are no extra checks. But, it may be more intuitive for the check to be in the MiniYARNCluster start so that it is obvious that the RM is only explicitly transitioned to active in HA setups. The check is made either way, it's just a matter of where we want the check to occur. Currently it is in the RM start method, but if you feel that it is better to put it in the MiniYARNCluster start method then we can add the check there. > MiniYARNCluster.start() returns before cluster is completely started > -------------------------------------------------------------------- > > Key: YARN-4686 > URL: https://issues.apache.org/jira/browse/YARN-4686 > Project: Hadoop YARN > Issue Type: Bug > Components: test > Reporter: Rohith Sharma K S > Assignee: Eric Badger > Attachments: MAPREDUCE-6507.001.patch, YARN-4686.001.patch, > YARN-4686.002.patch, YARN-4686.003.patch, YARN-4686.004.patch, > YARN-4686.005.patch, YARN-4686.006.patch > > > TestRMNMInfo fails intermittently. Below is trace for the failure > {noformat} > testRMNMInfo(org.apache.hadoop.mapreduce.v2.TestRMNMInfo) Time elapsed: 0.28 > sec <<< FAILURE! > java.lang.AssertionError: Unexpected number of live nodes: expected:<4> but > was:<3> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at > org.apache.hadoop.mapreduce.v2.TestRMNMInfo.testRMNMInfo(TestRMNMInfo.java:111) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)