[ 
https://issues.apache.org/jira/browse/YARN-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211213#comment-15211213
 ] 

Arun Suresh commented on YARN-2883:
-----------------------------------

Couple of nits with the latest patch :
* Why are we using {{ConcurrentSkipListMap}} instead of {{ConcurrentHashMap}} 
in the QueuingContext ? This would also require the keys to be Comparable which 
I don't think the {{ContainerTokenIdentifier}} (used as the key for 
{{killedQueuedContainers}}) is.
* In {{QueuingContainersMonitorImpl}}, line 74, you do not need to specify the 
Type in the {{new HashSet<ContainerId>()}}


> Queuing of container requests in the NM
> ---------------------------------------
>
>                 Key: YARN-2883
>                 URL: https://issues.apache.org/jira/browse/YARN-2883
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-2883-trunk.004.patch, YARN-2883-trunk.005.patch, 
> YARN-2883-yarn-2877.001.patch, YARN-2883-yarn-2877.002.patch, 
> YARN-2883-yarn-2877.003.patch, YARN-2883-yarn-2877.004.patch
>
>
> We propose to add a queue in each NM, where queueable container requests can 
> be held.
> Based on the available resources in the node and the containers in the queue, 
> the NM will decide when to allow the execution of a queued container.
> In order to ensure the instantaneous start of a guaranteed-start container, 
> the NM may decide to pre-empt/kill running queueable containers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to