[ 
https://issues.apache.org/jira/browse/YARN-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212928#comment-15212928
 ] 

Rohith Sharma K S commented on YARN-4880:
-----------------------------------------

I thought about this initially but since it start new ZK server I felt it is 
not necessarily required to start new ZK server when user is specifying 
external ZK host and port. And also default port at which curatorTestingServer 
try to start is 2181. But if external zk is running with default port and this 
test is in same machine, then we may face port issues.

> Running TestZKRMStateStorePerf with real zookeeper cluster throws NPE
> ---------------------------------------------------------------------
>
>                 Key: YARN-4880
>                 URL: https://issues.apache.org/jira/browse/YARN-4880
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Rohith Sharma K S
>
> While going throw TestZKRMStateStorePerf class , found that we are not 
> initializing variable {{TestingServer curatorTestingServer}} if real 
> zookeeper cluster are passed to utility.  But down the line , this variables 
> are used which causes NPE
> I tested by passing program arguments which result in NPE
> {noformat} 
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in 
> [jar:file:/C:/Users/r00902292/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in 
> [jar:file:/C:/Users/r00902292/.m2/repository/ch/qos/logback/logback-classic/1.1.2/logback-classic-1.1.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2016-03-26 14:47:50,937 INFO  [main] recovery.TestZKRMStateStore 
> (TestZKRMStateStorePerf.java:run(119)) - Starting ZKRMStateStorePerf ver.0.1
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf.initStore(TestZKRMStateStorePerf.java:102)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf.run(TestZKRMStateStorePerf.java:156)
>       at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
>       at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf.main(TestZKRMStateStorePerf.java:273)
> {noformat}
> There are 2 places variable {{curatorTestingServer}} used that need to be 
> guarded with null check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to