[
https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222023#comment-15222023
]
Yufei Gu commented on YARN-4807:
--------------------------------
Thanks [~ka...@cloudera.com] for detailed review.
1. Yes. Besides, I also use "private final boolean useNullRMNodeLabelsManager"
instead of "final private boolean useNullRMNodeLabelsManager".
2. Modified as suggested.
3. Modified as suggested. For the minimum waiting time, I mentions it as one
inconsistency in previous comment. Thanks for the explain.
4 and 5. I mentioned them as one consistency as well. It's not too work, but we
just need to decide to do it here or next JIRA.
6. Nice suggestion. But to move {{int loop = 0}} to the first for loop will
make second for loop have no init value for {{loop}}.
{{loop}} to {{retries}}, yeah, good idea.
> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
> Key: YARN-4807
> URL: https://issues.apache.org/jira/browse/YARN-4807
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Labels: newbie
> Attachments: YARN-4807.001.patch, YARN-4807.002.patch,
> YARN-4807.003.patch, YARN-4807.004.patch, YARN-4807.005.patch,
> YARN-4807.006.patch
>
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is
> significant duplication with MockRM#waitForState.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
