[jira] [Commented] (YARN-4630) Remove useless boxing/unboxing code (Hadoop YARN)

[Akira AJISAKA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231657#comment-15231657
 ] 

Akira AJISAKA commented on YARN-4630:
-------------------------------------

Hi [~sarutak], thank you for updating the patch.
{code}
  public int compareTo(ContainerId other) {
    int result = this.getApplicationAttemptId().compareTo(
        other.getApplicationAttemptId()) == 0;
{code}
Would you remove {{== 0}} to fix compilation error?

> Remove useless boxing/unboxing code (Hadoop YARN)
> -------------------------------------------------
>
>                 Key: YARN-4630
>                 URL: https://issues.apache.org/jira/browse/YARN-4630
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 3.0.0
>            Reporter: Kousuke Saruta
>            Assignee: Kousuke Saruta
>            Priority: Minor
>         Attachments: YARN-4630.0.patch, YARN-4630.1.patch
>
>
> There are lots of places where useless boxing/unboxing occur.
> To avoid performance issue, let's remove them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)