[ 
https://issues.apache.org/jira/browse/YARN-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Po updated YARN-4957:
--------------------------
    Attachment: YARN-4957.v2.patch

In YARN-4957.v2.patch I fixed the findbugs and Javadoc issues. The findbugs 
related to unused empty constructor is incorrect because the empty constructor 
is actually used in RecordFactoryPBImpl. 

*+Test Failures:+*

+Test:+ [testNodeLabelContainerAllocation.testQueueUsedCapacitiesUpdate]
Existing JIRA: 
https://issues.apache.org/jira/browse/YARN-4890?jql=text%20~%20%22TestNodeLabelContainerAllocation%22
 
This test passes locally.
----
+Tests:+[TestClientRMTokens.testShortCircuitRenewCancelDifferentHostSamePort, 
TestClientRMTokens.testShortCircuitRenewCancelDifferentHostDifferentPort, 
TestClientRMTokens.testShortCircuitRenewCancelSameHostDifferentPort, 
TestClientRMTokens.testShortCircuitRenewCancel:285->checkShortCircuitRenewCancel,
 TestClientRMTokens.testShortCircuitRenewCancelWildcardAddress, 
TestAMAuthorization.testUnauthorizedAccess]
Existing JIRA: https://issues.apache.org/jira/browse/HADOOP-12687
These tests pass locally.
----
+Tests:+ [TestAMRestart.testAMRestartNotLostContainerCompleteMsg]
This test passes locally if I change the timeout to 40 seconds. Right now, it 
is set at 30, but takes 37 seconds to complete. The result of this test seems  
dependent on the machine on which it is run. 
----
+Tests:+ [TestNodeLabelContainerAllocation.testQueueUsedCapacitiesUpdate]
Existing JIRA: 
https://issues.apache.org/jira/browse/YARN-4890?jql=text%20~%20%22TestNodeLabelContainerAllocation%22
This test passes locally.
----
+Tests:+ [TestSchedulingPolicy.testIsApplicableTo]
This test passes locally if I change the timeout to 3 seconds. Right now, it is 
set to 1 second, but takes 2.9 seconds to complete.he result of this test seems 
 dependent on the machine on which it is run. 
----
+Tests:+ [TestUberAM.testSleepJob, TestUberAM.testSleepJobWithMultipleReducers, 
TestUberAM.testRandomWriter, TestUberAM>TestMRJobs.testSleepJobWithRemoteJar]
Existing JIRA: 
https://issues.apache.org/jira/browse/MAPREDUCE-6681?jql=text%20~%20%22TestUberAM%22
This test fails locally. It also fails locally on trunk.
----
+Tests:+ [TestAMRMProxy.testAMRMProxyE2E, TestAMRMProxy.testE2ETokenSwap, 
TestAMRMProxy.testE2ETokenRenewal]
Existing JIRA: There was no existing JIRA, but I have found evidence that this 
test fails on other open JIRAs as well. 
https://builds.apache.org/job/PreCommit-YARN-Build/11016/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt
These tests pass locally.
----
+Tests:+ [TestYarnClient.testShouldNotRetryForeverForNonNetworkExceptions, 
TestYarnClient.testAMMRTokens, TestYarnClient.testSubmitIncorrectQueue]
Existing JIRAs: 
[https://issues.apache.org/jira/browse/YARN-4935?jql=text%20~%20%22TestAMRMProxy%22,
 
https://builds.apache.org/job/PreCommit-YARN-Build/11016/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt].
 The second link is evidence of other opened JIRA having the same failure.
These tests pass locally.
----
+Tests:+ [TestGetGroups>GetGroupsTestBase.testMultipleNonExistingUsers, 
TestGetGroups>GetGroupsTestBase.testExistingInterleavedWithNonExistentUsers, 
TestGetGroups>GetGroupsTestBase.testNoUserGiven, 
TestGetGroups>GetGroupsTestBase.testExistingUser]
Existing JIRA: 
https://issues.apache.org/jira/browse/YARN-4351?jql=text%20~%20%22TestGetGroups%22
These tests pass locally.

> Add getNewReservation in ApplicationClientProtocol
> --------------------------------------------------
>
>                 Key: YARN-4957
>                 URL: https://issues.apache.org/jira/browse/YARN-4957
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: applications, client, resourcemanager
>    Affects Versions: 2.8.0
>            Reporter: Subru Krishnan
>            Assignee: Sean Po
>              Labels: api-breaking
>         Attachments: YARN-4957.v0.patch, YARN-4957.v1.patch, 
> YARN-4957.v2.patch
>
>
> Currently submitReservation returns a ReservationId if sucessful. This JIRA 
> propose adding a getNewReservation in ApplicationClientProtocol for the 
> following reasons:
>   * Prevent zombie reservations in the face of client and/or network failures 
> post submitReservation
>   * Align reservation submission with application submission



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to