[ 
https://issues.apache.org/jira/browse/YARN-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262685#comment-15262685
 ] 

Allen Wittenauer commented on YARN-4734:
----------------------------------------

bq. Patch looks fine for me.

Umm, it's pretty clear that -08 hasn't been properly rebased to trunk given 
it's trying to add all of create-release.sh back.

bq. My understanding is BUILDING.txt should only contain how to build 
components. YarnUI2.md is majorly about how to deploy and start new UI server. 
Contributor/volunteer can try it follow the steps.

* Why is there a BUILD section then if you acknowledge building.txt?
* "Packaging and deploying Hadoop in this branch" --- umm, this is trunk!
* "This is a WIP project, nobody should use it in production." yet there is an 
attempt to put -Pyarnui into create-release.  One or other, not both.
* Why isn't "try it" automated?  Why can't we run this inside the RM or tomcat? 
If we really need a 3rd or 4th app server, why hasn't ember been integrated 
into the distribution like tomcat?
* If this is all completely optional anyway, is YarnUI2 the proper name?  
Sounds like it should be "alternate".

Moving on...

* Patch contains an extra modification to LevelDBCacheTimelineStore.java?
* Has this actually been tried to be used from a tar ball install? 

> Merge branch:YARN-3368 to trunk
> -------------------------------
>
>                 Key: YARN-4734
>                 URL: https://issues.apache.org/jira/browse/YARN-4734
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-4734.1.patch, YARN-4734.2.patch, YARN-4734.3.patch, 
> YARN-4734.4.patch, YARN-4734.5.patch, YARN-4734.6.patch, YARN-4734.7.patch, 
> YARN-4734.8.patch
>
>
> YARN-2928 branch is planned to merge back to trunk shortly, it depends on 
> changes of YARN-3368. This JIRA is to track the merging task.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to