[
https://issues.apache.org/jira/browse/YARN-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265413#comment-15265413
]
Sangjin Lee commented on YARN-4447:
-----------------------------------
Some more feedback...
(TimelineParserForCompareExpr.java)
- Most of these comments apply to other parser classes...
- Overall, catching {{Exception}}s is too broad. This way, it can catch all
kinds of unexpected exceptions and handle them. Can we tighten exceptions that
can be thrown off of {{parse()}}? Perhaps a new exception like
{{ParseException}} (instead of {{IllegalArgumentException}}) would be clearer?
- l.34: angle brackets in javadoc should be escaped
- l.69: I would recommend using the {{Deque}} interface (and {{LinkedList}})
over {{Stack}}, as {{Stack}} has unnecessary synchronization overhead
- l.75: this is where you can lowercase the expression
(TimelineReaderWebServicesUtils.java)
- Does {{parseDataToRetrieve()}} merit its own {{TimelineParser()}} impl? It
fits with the rest of the parser classes
(test code)
- How much negative testing (e.g. invalid expressions) is covered? Do we need
to cover more of error cases?
> Provide a mechanism to represent complex filters and parse them at the REST
> layer
> ----------------------------------------------------------------------------------
>
> Key: YARN-4447
> URL: https://issues.apache.org/jira/browse/YARN-4447
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: Timeline-Filters.pdf, YARN-4447-YARN-2928.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
