[
https://issues.apache.org/jira/browse/YARN-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266750#comment-15266750
]
Junping Du commented on YARN-4920:
----------------------------------
Thanks [~xgong] for updating the patch! The v4 patch looks pretty good. Only a
minor comments:
{noformat}
+ private boolean isRunningState(YarnApplicationState appState) {
+ return appState == YarnApplicationState.ACCEPTED
+ || appState == YarnApplicationState.RUNNING;
+ }
{noformat}
YarnApplicationState.ACCEPTED shouldn't been recognized as running state as it
indicates RM haven't receive AM's registration so no container should be
running.
Other looks fine to me.
> ATS/NM should support a link to dowload/get the logs in text format
> -------------------------------------------------------------------
>
> Key: YARN-4920
> URL: https://issues.apache.org/jira/browse/YARN-4920
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-4920.2.patch, YARN-4920.20160424.branch-2.patch,
> YARN-4920.3.patch, YARN-4920.4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
