[
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266958#comment-15266958
]
John Zhuge commented on YARN-4994:
----------------------------------
Nice work, [~boky01].
TestHadoopArchiveLogsRunner.java:
* 134-136: put {{fs}} into try clause since it is {{AutoCloseable}}.
TestHedgingRequestRMFailoverProxyProvider.java
* 43: any change?
* 45: any change?
TestAMRMProxy.java
* 163-165, 241-243, 282-284: put {{rmClient}} into try clause since it is
{{AutoCloseable}}
TestYarnCLI.java
* 1583-1585: put {{yarnClient}} into try clause since it is {{AutoCloseable}}
TestMiniYarnCluster.java
* 45, 62, 91: javac errors, switch to non-deprecated constructor?
> Use MiniYARNCluster with try-with-resources in tests
> ----------------------------------------------------
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
> Affects Versions: 2.7.0
> Reporter: Andras Bokor
> Assignee: Andras Bokor
> Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch,
> HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
> is preferred since Java7 instead of the pattern above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
