[ https://issues.apache.org/jira/browse/YARN-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bibin A Chundatt updated YARN-5024: ----------------------------------- Attachment: 0004-YARN-5024.patch [~templedf] Thank you for review comments. Yes need to only take care that {{waitForState}} is not called for {{COMPLETED}} containers since its will return {{null}} {{FicaSchedulerApp#containerCompleted}} on container completion removes from {{liveContainers}}. {code} public synchronized boolean containerCompleted(RMContainer rmContainer, ContainerStatus containerStatus, RMContainerEventType event, String partition) { ContainerId containerId = rmContainer.getContainerId(); // Remove from the list of containers if (null == liveContainers.remove(containerId)) { return false; } {code} {{getResourceScheduler().getRMContainer(containerId);}} {code} @Override public RMContainer getRMContainer(ContainerId containerId) { SchedulerApplicationAttempt attempt = getCurrentAttemptForContainer(containerId); return (attempt == null) ? null : attempt.getRMContainer(containerId); } {code} {{SchedulerApplicationAttempt#getRMContainer}} {code} public synchronized RMContainer getRMContainer(ContainerId id) { return liveContainers.get(id); } {code} Updating patch using {{MockRM}} > TestContainerResourceUsage#testUsageAfterAMRestartWithMultipleContainers > random failure > --------------------------------------------------------------------------------------- > > Key: YARN-5024 > URL: https://issues.apache.org/jira/browse/YARN-5024 > Project: Hadoop YARN > Issue Type: Test > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Attachments: 0001-YARN-5024.patch, 0002-YARN-5024.patch, > 0003-YARN-5024.patch, 0004-YARN-5024.patch > > > Random Testcase failure for > {{TestContainerResourceUsage#testUsageAfterAMRestartWithMultipleContainers}} > {noformat} > java.lang.AssertionError: Unexcpected MemorySeconds value > expected:<-1497214794931> but was:<1913> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at > org.apache.hadoop.yarn.server.resourcemanager.TestContainerResourceUsage.amRestartTests(TestContainerResourceUsage.java:395) > at > org.apache.hadoop.yarn.server.resourcemanager.TestContainerResourceUsage.testUsageAfterAMRestartWithMultipleContainers(TestContainerResourceUsage.java:252) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org