[
https://issues.apache.org/jira/browse/YARN-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284199#comment-15284199
]
Rohith Sharma K S commented on YARN-4837:
-----------------------------------------
After going through patch, apart from below nit, rest of all looks fine to me.
1. {{In AppSchedulingInfo#updateBlacklistedPlaces}} if-block can be written as
{{changed = blacklist.removeAll(blacklistRemovals)}}
2. I am little bit confused with naming convention for {{blacklist}} with
{{placesBlacklist}}. Can it be changed? And is there any plan to support
blacklist racks in the future? Just thought from the comment in
AppSchedulingInfo from the patch
{code}
// Set of places (nodes / racks) blacklisted by the system. Today, this only
79 // has places blacklisted for AM containers.
80 private final Set<String> placesBlacklistedBySystem = new HashSet<>();
81 private Set<String> placesBlacklistedByApp = new HashSet<>();
{code}
> User facing aspects of 'AM blacklisting' feature need fixing
> ------------------------------------------------------------
>
> Key: YARN-4837
> URL: https://issues.apache.org/jira/browse/YARN-4837
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Priority: Critical
> Attachments: YARN-4837-20160515.txt
>
>
> Was reviewing the user-facing aspects that we are releasing as part of 2.8.0.
> Looking at the 'AM blacklisting feature', I see several things to be fixed
> before we release it in 2.8.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
