[
https://issues.apache.org/jira/browse/YARN-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301503#comment-15301503
]
Hadoop QA commented on YARN-4757:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 44s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
16s {color} | {color:green} YARN-4757 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 44s
{color} | {color:green} YARN-4757 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
26s {color} | {color:green} YARN-4757 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 30s
{color} | {color:green} YARN-4757 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} YARN-4757 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source:
hadoop-project {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
33s {color} | {color:green} YARN-4757 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s
{color} | {color:green} YARN-4757 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 34s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 7m 9s {color}
| {color:red} root generated 1 new + 697 unchanged - 0 fixed = 698 total (was
697) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 34s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 23s
{color} | {color:red} root: patch generated 210 new + 47 unchanged - 0 fixed =
257 total (was 47) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 12 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patch modules with no Java source:
hadoop-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 36s
{color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry
generated 16 new + 0 unchanged - 0 fixed = 16 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 18s
{color} | {color:red} hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry
generated 39 new + 52 unchanged - 0 fixed = 91 total (was 52) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s
{color} | {color:green} hadoop-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 57s
{color} | {color:green} hadoop-yarn-registry in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 21s
{color} | {color:red} Patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 51s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry |
| | Possible null pointer dereference of event in
org.apache.hadoop.registry.client.impl.zk.CuratorService$1.childEvent(CuratorFramework,
TreeCacheEvent) Dereferenced at CuratorService.java:event in
org.apache.hadoop.registry.client.impl.zk.CuratorService$1.childEvent(CuratorFramework,
TreeCacheEvent) Dereferenced at CuratorService.java:[line 804] |
| | Switch statement found in
org.apache.hadoop.registry.client.impl.zk.CuratorService$1.childEvent(CuratorFramework,
TreeCacheEvent) where default case is missing At
CuratorService.java:TreeCacheEvent) where default case is missing At
CuratorService.java:[lines 804-819] |
| | Boxing/unboxing to parse a primitive
org.apache.hadoop.registry.server.dns.BaseServiceRecordProcessor$ApplicationRecordDescriptor.getPort(Endpoint)
At
BaseServiceRecordProcessor.java:org.apache.hadoop.registry.server.dns.BaseServiceRecordProcessor$ApplicationRecordDescriptor.getPort(Endpoint)
At BaseServiceRecordProcessor.java:[line 337] |
| | Possible null pointer dereference of dnsApi in
org.apache.hadoop.registry.server.dns.BaseServiceRecordProcessor$ApplicationRecordDescriptor.getDNSApiFragment(String)
Dereferenced at BaseServiceRecordProcessor.java:dnsApi in
org.apache.hadoop.registry.server.dns.BaseServiceRecordProcessor$ApplicationRecordDescriptor.getDNSApiFragment(String)
Dereferenced at BaseServiceRecordProcessor.java:[line 374] |
| | Bitwise add of signed byte value computed in
org.apache.hadoop.registry.server.dns.RegistryDNS.getMessgeLength(ByteBuffer)
At RegistryDNS.java:value computed in
org.apache.hadoop.registry.server.dns.RegistryDNS.getMessgeLength(ByteBuffer)
At RegistryDNS.java:[line 635] |
| | Dead store to read in
org.apache.hadoop.registry.server.dns.RegistryDNS.NIOTCPClient(SocketChannel)
At
RegistryDNS.java:org.apache.hadoop.registry.server.dns.RegistryDNS.NIOTCPClient(SocketChannel)
At RegistryDNS.java:[line 587] |
| | Found reliance on default encoding in
org.apache.hadoop.registry.server.dns.RegistryDNS.enableDNSSECIfNecessary(Zone,
Configuration, SOARecord, NSRecord):in
org.apache.hadoop.registry.server.dns.RegistryDNS.enableDNSSECIfNecessary(Zone,
Configuration, SOARecord, NSRecord): String.getBytes() At
RegistryDNS.java:[line 468] |
| | Null pointer dereference of zone in
org.apache.hadoop.registry.server.dns.RegistryDNS.getNXTRecord(Record)
Dereferenced at RegistryDNS.java:in
org.apache.hadoop.registry.server.dns.RegistryDNS.getNXTRecord(Record)
Dereferenced at RegistryDNS.java:[line 1221] |
| | Load of known null value in
org.apache.hadoop.registry.server.dns.RegistryDNS.getNXTRecord(Record) At
RegistryDNS.java:in
org.apache.hadoop.registry.server.dns.RegistryDNS.getNXTRecord(Record) At
RegistryDNS.java:[line 1221] |
| |
org.apache.hadoop.registry.server.dns.RegistryDNS.enableDNSSECIfNecessary(Zone,
Configuration, SOARecord, NSRecord) may fail to clean up java.io.InputStream
Obligation to clean up resource created at RegistryDNS.java:fail to clean up
java.io.InputStream Obligation to clean up resource created at
RegistryDNS.java:[line 483] is not discharged |
| |
org.apache.hadoop.registry.server.dns.RegistryDNS.enableDNSSECIfNecessary(Zone,
Configuration, SOARecord, NSRecord) may fail to close stream At
RegistryDNS.java:fail to close stream At RegistryDNS.java:[line 483] |
| | Nullcheck of zone at line 1112 of value previously dereferenced in
org.apache.hadoop.registry.server.dns.RegistryDNS.addAnswer(Message, Name, int,
int, int, int) At RegistryDNS.java:1112 of value previously dereferenced in
org.apache.hadoop.registry.server.dns.RegistryDNS.addAnswer(Message, Name, int,
int, int, int) At RegistryDNS.java:[line 1112] |
| | Exceptional return value of
java.util.concurrent.ExecutorService.submit(Callable) ignored in
org.apache.hadoop.registry.server.dns.RegistryDNS.addNIOTCP(InetAddress, int)
At RegistryDNS.java:ignored in
org.apache.hadoop.registry.server.dns.RegistryDNS.addNIOTCP(InetAddress, int)
At RegistryDNS.java:[line 698] |
| | Exceptional return value of
java.util.concurrent.ExecutorService.submit(Callable) ignored in
org.apache.hadoop.registry.server.dns.RegistryDNS.addNIOUDP(InetAddress, int)
At RegistryDNS.java:ignored in
org.apache.hadoop.registry.server.dns.RegistryDNS.addNIOUDP(InetAddress, int)
At RegistryDNS.java:[line 723] |
| | Exceptional return value of
java.util.concurrent.ExecutorService.submit(Callable) ignored in
org.apache.hadoop.registry.server.dns.RegistryDNS.serveNIOTCP(ServerSocketChannel,
InetAddress, int) At RegistryDNS.java:ignored in
org.apache.hadoop.registry.server.dns.RegistryDNS.serveNIOTCP(ServerSocketChannel,
InetAddress, int) At RegistryDNS.java:[line 652] |
| | Should org.apache.hadoop.registry.server.dns.RegistryDNS$CloseableLock be
a _static_ inner class? At RegistryDNS.java:inner class? At
RegistryDNS.java:[lines 1490-1502] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:2c91fd8 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806284/YARN-4757-YARN-4757.001.patch
|
| JIRA Issue | YARN-4757 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml findbugs checkstyle |
| uname | Linux 26ebae20d200 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | YARN-4757 / 9a31e5d |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
| javac | root:
https://builds.apache.org/job/PreCommit-YARN-Build/11705/artifact/patchprocess/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/11705/artifact/patchprocess/diff-checkstyle-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/11705/artifact/patchprocess/whitespace-tabs.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-YARN-Build/11705/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry.html
|
| javadoc | hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry:
https://builds.apache.org/job/PreCommit-YARN-Build/11705/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-registry.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/11705/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-YARN-Build/11705/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-project
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: . |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/11705/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
> [Umbrella] Simplified discovery of services via DNS mechanisms
> --------------------------------------------------------------
>
> Key: YARN-4757
> URL: https://issues.apache.org/jira/browse/YARN-4757
> Project: Hadoop YARN
> Issue Type: New Feature
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Jonathan Maron
> Attachments:
> 0001-YARN-4757-Initial-code-submission-for-DNS-Service.patch, YARN-4757-
> Simplified discovery of services via DNS mechanisms.pdf,
> YARN-4757-YARN-4757.001.patch
>
>
> [See overview doc at YARN-4692, copying the sub-section (3.2.10.2) to track
> all related efforts.]
> In addition to completing the present story of service-registry (YARN-913),
> we also need to simplify the access to the registry entries. The existing
> read mechanisms of the YARN Service Registry are currently limited to a
> registry specific (java) API and a REST interface. In practice, this makes it
> very difficult for wiring up existing clients and services. For e.g, dynamic
> configuration of dependent endpoints of a service is not easy to implement
> using the present registry-read mechanisms, *without* code-changes to
> existing services.
> A good solution to this is to expose the registry information through a more
> generic and widely used discovery mechanism: DNS. Service Discovery via DNS
> uses the well-known DNS interfaces to browse the network for services.
> YARN-913 in fact talked about such a DNS based mechanism but left it as a
> future task. (Task) Having the registry information exposed via DNS
> simplifies the life of services.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
