[
https://issues.apache.org/jira/browse/YARN-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302086#comment-15302086
]
Varun Vasudev commented on YARN-4007:
-------------------------------------
Thanks for the patch [~sidharta-s]. Comments on the patch -
# Can you fix the following checkstyle issues -
{code}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:1379:
public static final String [] DEFAULT_NM_DOCKER_ALLOWED_CONTAINER_NETWORKS
=:29: 'String' is followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:1380:
{ "host", "none", "bridge" };:8: '{' is followed by whitespace.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java:387:
String[] testCapabilities = {"NET_BIND_SERVICE", "SYS_CHROOT"};:14:
'testCapabilities' hides a field.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java:399:
String[] networks = { "host", "none", "bridge", customNetwork1,:26: '{' is
followed by whitespace.
{code}
# In testContainerLaunchWithNetworkingDefaults() - can you set
YarnConfiguration.NM_DOCKER_ALLOWED_CONTAINER_NETWORKS in the test? It looks
like you're relying on the order in which the tests run
# {code}
+ //default network is "sdn3"
+ conf.set(YarnConfiguration.NM_DOCKER_DEFAULT_CONTAINER_NETWORK,
+ customNetwork1);
{code}
Comment doesn't match code - actual default network is sdn1
Rest of the patch looks good to me.
> Add support for different network setups when launching the docker container
> ----------------------------------------------------------------------------
>
> Key: YARN-4007
> URL: https://issues.apache.org/jira/browse/YARN-4007
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.8.0
> Reporter: Varun Vasudev
> Assignee: Sidharta Seethana
> Attachments: YARN-4007.001.patch
>
>
> We should allow users to be able to launch containers with appropriate
> network setups. For security, we should allow admins to provide a set of
> options that the users are allowed to use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
