[ https://issues.apache.org/jira/browse/YARN-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310766#comment-15310766 ]
Daniel Templeton commented on YARN-4996: ---------------------------------------- Awesome. Thanks, [~lewuathe]. Now, add some javadocs for the {{getScheduler()}} method, and I think it's looking good. > Make TestNMReconnect.testCompareRMNodeAfterReconnect() scheduler agnostic, or > better yet parameterized > ------------------------------------------------------------------------------------------------------ > > Key: YARN-4996 > URL: https://issues.apache.org/jira/browse/YARN-4996 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager, test > Affects Versions: 2.8.0 > Reporter: Daniel Templeton > Assignee: Kai Sasaki > Priority: Minor > Labels: newbie > Attachments: YARN-4996.01.patch, YARN-4996.02.patch, > YARN-4996.03.patch, YARN-4996.04.patch, YARN-4996.05.patch > > > The test tests only the capacity scheduler. It should also test fair > scheduler. At a bare minimum, it should use the default scheduler. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org