[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311209#comment-15311209
]
Wangda Tan commented on YARN-5047:
----------------------------------
[~kasha]/[~rchiang].
bq. Unlike other schedulers, CS seems to call allocateContainersToNode in
handle() instead of nodeUpdate. May be CS should also override nodeUpdate and
call this method there for uniformity as we refactor things around this? This
would in preparation for moving handle() itself to AbstractYarnScheduler. /cc
Wangda Tan
Not entirely sure if I understand the proposal. It looks like a good solution
if we can add an abstract {{assignContainers}} to AbstractYarnScheduler as you
proposed above, call assginContainers from
AbstractYarnScheduler#assignContainers, and move allocateContainersToNode to
assignContainers.
> Refactor nodeUpdate across schedulers
> -------------------------------------
>
> Key: YARN-5047
> URL: https://issues.apache.org/jira/browse/YARN-5047
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, fairscheduler, scheduler
> Affects Versions: 3.0.0-alpha1
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Attachments: YARN-5047.001.patch, YARN-5047.002.patch,
> YARN-5047.003.patch
>
>
> FairScheduler#nodeUpdate() and CapacityScheduler#nodeUpdate() have a lot of
> commonality in their code. See about refactoring the common parts into
> AbstractYARNScheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
