[ 
https://issues.apache.org/jira/browse/YARN-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312423#comment-15312423
 ] 

Varun Vasudev commented on YARN-5191:
-------------------------------------

Thanks for the patch Xuan. Couple of things -
# We should restrict the formats to "text" and "octet-stream". In case of text, 
the Content-Type should be set to "text/plain" and in case of octet-stream it 
should be set to "application/octet-stream"
# Please add the header "X-Content-Type-Options" and set it to "nosniff"

Thanks!

> Rename the “download=true” option for getLogs in NMWebServices and 
> AHSWebServices
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-5191
>                 URL: https://issues.apache.org/jira/browse/YARN-5191
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-5191.1.patch
>
>
> Rename the “download=true” option to instead be something like 
> “format=octet-stream”, so that we are explicit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to