[ https://issues.apache.org/jira/browse/YARN-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317740#comment-15317740 ]
Naganarasimha G R commented on YARN-4308: ----------------------------------------- Hi [~sunilg], Overall the changes looks good but we could have avoided {{MockCPUResourceCalculatorProcessTree}} and just used {{Mockito.when along with Mockito.thenReturn(Value1,value2...)}}. thoughts? > ContainersAggregated CPU resource utilization reports negative usage in first > few heartbeats > -------------------------------------------------------------------------------------------- > > Key: YARN-4308 > URL: https://issues.apache.org/jira/browse/YARN-4308 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.7.1 > Reporter: Sunil G > Assignee: Sunil G > Attachments: 0001-YARN-4308.patch, 0002-YARN-4308.patch, > 0003-YARN-4308.patch, 0004-YARN-4308.patch, 0005-YARN-4308.patch, > 0006-YARN-4308.patch, 0007-YARN-4308.patch, 0008-YARN-4308.patch, > 0009-YARN-4308.patch > > > NodeManager reports ContainerAggregated CPU resource utilization as -ve value > in first few heartbeats cycles. I added a new debug print and received below > values from heartbeats. > {noformat} > INFO > org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl: > ContainersResource Utilization : CpuTrackerUsagePercent : -1.0 > INFO > org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl:ContainersResource > Utilization : CpuTrackerUsagePercent : 198.94598 > {noformat} > Its better we send 0 as CPU usage rather than sending a negative values in > heartbeats eventhough its happening in only first few heartbeats. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org