[ 
https://issues.apache.org/jira/browse/YARN-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319328#comment-15319328
 ] 

Konstantinos Karanasos commented on YARN-5176:
----------------------------------------------

Thanks for the review, [~asuresh]!

I agree with creating a parameterized test for testing both 
{{ContainerManagerImpl}} and {{QueuingContainerManagerImpl}} against the 
original tests written for the {{ContainerManagerImpl}}.

I increased the timeout from 20 to 30sec (locally the test case runs properly). 
I think it should be a timing issue, because the ContainerImpl goes from 
CONTAINER_CLEANEDUP_AFTER_KILL to DONE state, so if we wait long enough, we 
should always reach the DONE state. Will upload the new patch now to kick off 
Jenkins.

> More test cases for queuing of containers at the NM
> ---------------------------------------------------
>
>                 Key: YARN-5176
>                 URL: https://issues.apache.org/jira/browse/YARN-5176
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-5176.001.patch, YARN-5176.002.patch
>
>
> Extending {{TestQueuingContainerManagerImpl}} to include more test cases for 
> the queuing of containers at the NM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to