[ 
https://issues.apache.org/jira/browse/YARN-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320712#comment-15320712
 ] 

Rohith Sharma K S commented on YARN-5208:
-----------------------------------------

bq. Since this issue will hit for those test cases which connects through 
proxy, we can write some clear java doc and comments explaining the reason. For 
these kinds of tests cases, we must use IP as host resolver.
Initially I thought of either adding java-doc OR adding a comment. But I could 
not get right place to add where contributors can be seen. And I felt that most 
of the time, java-doc/comments will be unnoticed. Would you/anyone suggest 
where it could be a right place to add so that it should be known to 
contributors.

bq. In TestAMRMClientOnRMRestart#tearDown, NULL check for conf is not needed. 
We can create a new conf object and set it.
Since conf object is static variable in the class, it is reused instead of 
creating new one.

> Run TestAMRMClient TestNMClient TestYarnClient TestClientRMTokens 
> TestAMAuthorization tests with hadoop.security.token.service.use_ip enabled
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5208
>                 URL: https://issues.apache.org/jira/browse/YARN-5208
>             Project: Hadoop YARN
>          Issue Type: Test
>          Components: test
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>            Priority: Blocker
>              Labels: test
>         Attachments: 0001-YARN-5208.patch, 0002-YARN-5208.patch, 
> 0003-YARN-5208.patch, 0004-YARN-5208.patch
>
>
> All YARN test cases are running with *hadoop.security.token.service.use_ip* 
> disabled. As a result few tests {{TestAMRMClient TestNMClient TestYarnClient 
> TestClientRMTokens TestAMRMTokens}} cases are consistently failing because of 
> unable to resolve hostname(see HADOOP-12687 YARN-4306 YARN-4318)
> I would suggest to run tests with *hadoop.security.token.service.use_ip* 
> enabled by default. And for the HA test cases which require mandatory 
> disabling , change test cases as required by setting 
> {code}
> conf.setBoolean(
>         CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP, false);
>     SecurityUtil.setConfiguration(conf);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to