[ https://issues.apache.org/jira/browse/YARN-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Suresh updated YARN-5124: ------------------------------ Attachment: YARN-5124.015.patch Thanks for the review [~kasha].. Uploading patch addressing your concerns: bq. RequestInfoIterator does not implement remove. Hmmm.. I intentionally left it out, since it is a bit complicated and is not used by {{AMRMClientImpl}}. I vote we put that in, when its required. bq. The naming of helper methods getLocationMap etc. can be more explicit. e.g. getRemoteRequestsForLocation So, it is not really returning a map of RemoteRequests for the location, it is actually a sub-map, so a more descriptive name might be hard. Given that I have docuemnted in a comment on the Key used by the root map, I am hoping we can just keep this as it is, also, it is a package protected method only to be used by AMRMClientImpl. > Modify AMRMClient to set the ExecutionType in the ResourceRequest > ----------------------------------------------------------------- > > Key: YARN-5124 > URL: https://issues.apache.org/jira/browse/YARN-5124 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Attachments: YARN-5124.001.patch, YARN-5124.002.patch, > YARN-5124.003.patch, YARN-5124.004.patch, YARN-5124.005.patch, > YARN-5124.006.patch, YARN-5124.008.patch, YARN-5124.009.patch, > YARN-5124.010.patch, YARN-5124.011.patch, YARN-5124.012.patch, > YARN-5124.013.patch, YARN-5124.014.patch, YARN-5124.015.patch, > YARN-5124_YARN-5180_combined.007.patch, YARN-5124_YARN-5180_combined.008.patch > > > Currently the {{ContainerRequest}} allows the AM to set the {{ExecutionType}} > in the AMRMClient, but it is not being set in the actual {{ResourceRequest}} > that is sent to the RM -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org