[ 
https://issues.apache.org/jira/browse/YARN-5239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325641#comment-15325641
 ] 

Joep Rottinghuis commented on YARN-5239:
----------------------------------------

No unit tests were added 'cause hit patch changes only documentation and 
imports. Tests ran locally and checkstyle came through clean.

> Eliminate unused imports checkstyle warnings
> --------------------------------------------
>
>                 Key: YARN-5239
>                 URL: https://issues.apache.org/jira/browse/YARN-5239
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>            Priority: Trivial
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5239-YARN-2928.01.patch
>
>
> There are ~8 existing checkstyle issues generated due to unused imports.
> By fully qualifying the classes in javadoc and manually wrapping the javadoc 
> under 80 characters we can eliminate these warnings.
> This will help with the eventual merge because then we introduce 8 fewer 
> checkstyle warnings.
> The only checkstyle warnings left are now too many arguments, which cannot be 
> easily refactored w/o changing code structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to