[
https://issues.apache.org/jira/browse/YARN-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327315#comment-15327315
]
Xianyin Xin edited comment on YARN-5241 at 6/13/16 1:06 PM:
------------------------------------------------------------
Thank you for reporting this, [~chenfolin]. So if the containers occasionally
exist in completed state of nodeHeartbeatRequest and in releaseList of
AllocateRequest, this problem would happen, right?
About your patch, could you please re-format it according to the hadoop code
conventions mentioned here [http://wiki.apache.org/hadoop/HowToContribute]? If
you can provide one patch based on trunk, that would be better. :)
cc [~kasha].
was (Author: xinxianyin):
Thank you for reporting this, [~chenfolin]. So if the containers occasionally
exist in completed state of nodeHeartbeatRequest and in releaseList of
AllocateRequest, this problem would happen, right?
About your patch, could you please re-format it according to the hadoop code
conventions mentioned here [http://wiki.apache.org/hadoop/HowToContribute]?
cc [~kasha].
> FairScheduler repeat container completed
> ----------------------------------------
>
> Key: YARN-5241
> URL: https://issues.apache.org/jira/browse/YARN-5241
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.5.0, 2.6.1, 2.8.0, 2.7.2
> Reporter: ChenFolin
> Attachments: YARN-5241-001.patch, repeatContainerCompleted.log
>
>
> NodeManager heartbeat event NODE_UPDATE and ApplicationMaster allocate
> operate may cause repeat container completed, it can lead something wrong.
> Node releaseContainer can pervent repeat release operate:
> like:
> public synchronized void releaseContainer(Container container) {
> if (!isValidContainer(container.getId())) {
> LOG.error("Invalid container released " + container);
> return;
> }
> FSAppAttempt containerCompleted did not prevent repeat container completed
> operate.
> Detail logs at attach file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
