[
https://issues.apache.org/jira/browse/YARN-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343231#comment-15343231
]
Arun Suresh commented on YARN-5171:
-----------------------------------
Thanks for the updated patch [~elgoiri]
The updated test case looks good, few comments:
# to ensure that we verify the fact that the AM is notified of the completed
containers, you should probably add an {{Assert.assertTrue(released);}} after
you exit from the for loop.
# You can remove the TODO.
With regard to the naming, I now feel the best way to avoid conflicts is to
probably rename {{isExternallAllocated()}} to
{{isAllocatedViaDistributedScheduler()}} and similarly, the
{{allocatedResourcesExternal}} to {{allocatedResourcesViaDistSched}}
> Extend DistributedSchedulerProtocol to notify RM of containers allocated by
> the Node
> ------------------------------------------------------------------------------------
>
> Key: YARN-5171
> URL: https://issues.apache.org/jira/browse/YARN-5171
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Inigo Goiri
> Attachments: YARN-5171.000.patch, YARN-5171.001.patch,
> YARN-5171.002.patch, YARN-5171.003.patch, YARN-5171.004.patch,
> YARN-5171.005.patch, YARN-5171.006.patch, YARN-5171.007.patch,
> YARN-5171.008.patch, YARN-5171.009.patch
>
>
> Currently, the RM does not know about Containers allocated by the
> OpportunisticContainerAllocator on the NM. This JIRA proposes to extend the
> Distributed Scheduler request interceptor and the protocol to notify the RM
> of new containers as and when they are allocated at the NM. The
> {{RMContainer}} should also be extended to expose the {{ExecutionType}} of
> the container.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
