[ https://issues.apache.org/jira/browse/YARN-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363103#comment-15363103 ]
Xuan Gong commented on YARN-5224: --------------------------------- Thanks for the review. Vinod. {code} ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerLogsInfo.java:0:: Missing package-info.java file. ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerLogsInfo.java:38: protected List<ContainerLogInfo> containerLogsInfo;:36: Variable 'containerLogsInfo' must be private and have accessor methods. {code} Looks like that those warnings exist for all web.dao objects. But I do add a Javadoc comment for ContainerLogsInfo object. bq. TestLogsCLI failure is related to recent changes? Looks like that they are related. TestLogsCLI.testFetchApplictionLogs is very unstable. It fails occasionally. But I can not reproduce it locally. TestLogsCLI.testFetchApplictionLogsAsAnotherUser fails because we have reverted HADOOP-12718 recently. Created a separate ticket for this issue: https://issues.apache.org/jira/browse/YARN-5313 > Logs for a completed container are not available in the yarn logs output for > a live application > ----------------------------------------------------------------------------------------------- > > Key: YARN-5224 > URL: https://issues.apache.org/jira/browse/YARN-5224 > Project: Hadoop YARN > Issue Type: Sub-task > Affects Versions: 2.9.0 > Reporter: Siddharth Seth > Assignee: Xuan Gong > Attachments: YARN-5224.1.patch, YARN-5224.2.patch, YARN-5224.3.patch, > YARN-5224.4.patch, YARN-5224.5.patch, YARN-5224.6.patch, > YARN-5224.6.trunk.patch, YARN-5224.7.trunk.patch, YARN-5224.8.branch-2.patch > > > This affects 'short' jobs like MapReduce and Tez more than long running apps. > Related: YARN-5193 (but that only covers long running apps) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org