[ https://issues.apache.org/jira/browse/YARN-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375435#comment-15375435 ]
Varun Vasudev commented on YARN-4759: ------------------------------------- Thanks for the patch [~shaneku...@gmail.com]. Patch looks mostly good. One minor change - {code} + // always change back + if (change_effective_user(user, group) != 0) { + return -1; + } {code} Can you please log an error message? > Revisit signalContainer() for docker containers > ----------------------------------------------- > > Key: YARN-4759 > URL: https://issues.apache.org/jira/browse/YARN-4759 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn > Reporter: Sidharta Seethana > Assignee: Shane Kumpf > Attachments: YARN-4759.001.patch, YARN-4759.002.patch > > > The current signal handling (in the DockerContainerRuntime) needs to be > revisited for docker containers. For example, container reacquisition on NM > restart might not work, depending on which user the process in the container > runs as. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org