[ 
https://issues.apache.org/jira/browse/YARN-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388595#comment-15388595
 ] 

Subru Krishnan commented on YARN-3662:
--------------------------------------

Thanks [~vvasudev] for reviewing the patches. 

I think there is a misunderstanding on the scope of these APIs - Federation 
does *not* add any public APIs (except for an Admin API which will be done in a 
separate JIRA) as the design philosophy we have followed in Federation is to be 
*transparent* to the applications. So the public APIs will be continue to be 
the standard YARN APIs (ApplicationClient/Master protocols). 

The Federation Store APIs are for analogous to {{RMStateStore}}. Subsequently 
we decided:
  * To have them in yarn-server and not in yarn-api.  I will add a limited 
audience of YARN to make it clear.
  * Minimize the wrapper request/response classes as they cause more overhead. 
I can add them if you still feel it's better to have them?

Regarding your rename suggestions, I'll update the method names accordingly. I 
do have a question, I prefer to have Federation as the prefix for 
request/response objects rather than the op (Get.../Set...) as it makes it 
easier to filter and also align with the package hierarchy. Thoughts?

The title of the JIRAs might have been misleading so I updated them to call out 
that these are internal APIs.

> Federation Membership State Store internal APIs
> -----------------------------------------------
>
>                 Key: YARN-3662
>                 URL: https://issues.apache.org/jira/browse/YARN-3662
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Subru Krishnan
>         Attachments: YARN-3662-YARN-2915-v1.1.patch, 
> YARN-3662-YARN-2915-v1.patch, YARN-3662-YARN-2915-v2.patch, 
> YARN-3662-YARN-2915-v3.01.patch, YARN-3662-YARN-2915-v3.patch, 
> YARN-3662-YARN-2915-v4.patch
>
>
> The Federation Application State encapsulates the information about the 
> active RM of each sub-cluster that is participating in Federation. The 
> information includes addresses for ClientRM, ApplicationMaster and Admin 
> services along with the sub_cluster _capability_ which is currently defined 
> by *ClusterMetricsInfo*. Please refer to the design doc in parent JIRA for 
> further details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to