[ https://issues.apache.org/jira/browse/YARN-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393076#comment-15393076 ]
Subru Krishnan commented on YARN-5203: -------------------------------------- Thanks [~ellenfkh] for the updated patch. It LGTM, just a few minor comments: * Rename {{testUnmarshallApp}} --> {{testUnmarshallAppInfo}} * Add an {{ExecutionTypeRequestInfo}} JAXB object, this will fix the findbugs warning too * It should be ok to have {{ResourceRequestInfo::resourceRequests}} as private [~sunilg], can you please take a look too? > Return ResourceRequest JAXB object in ResourceManager Cluster Applications > REST API > ----------------------------------------------------------------------------------- > > Key: YARN-5203 > URL: https://issues.apache.org/jira/browse/YARN-5203 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Subru Krishnan > Assignee: Ellen Hui > Labels: api-breaking, bug > Attachments: YARN-5203.v0.patch, YARN-5203.v1.patch, > YARN-5203.v2.patch, YARN-5203.v3.patch > > > The ResourceManager Cluster Applications REST API returns {{ResourceRequest}} > as String rather than a JAXB object. This prevents downstream tools like > Federation Router (YARN-3659) that depend on the REST API to unmarshall the > {{AppInfo}}. This JIRA proposes updating {{AppInfo}} to return a JAXB version > of the {{ResourceRequest}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org