[
https://issues.apache.org/jira/browse/YARN-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395628#comment-15395628
]
Varun Vasudev commented on YARN-5428:
-------------------------------------
Thanks for the patch [~shaneku...@gmail.com]. Some feedback -
1)
{code}
+ String clientConfigDir = conf.get(
+ YarnConfiguration.NM_DOCKER_CLIENT_CONFIG_DIRECTORY);
+ if(clientConfigDir != null) {
+ runCommand.setClientConfigDir(clientConfigDir);
+ }
+
{code}
{code}
+
+ String clientConfigDir = conf.get(
+ YarnConfiguration.NM_DOCKER_CLIENT_CONFIG_DIRECTORY);
+ if(clientConfigDir != null) {
+ stopCommand.setClientConfigDir(clientConfigDir);
+ }
+
{code}
Can we just move the null check into setClientConfigDir itself?
Rest of the patch looks good to me.
> Allow for specifying the docker client configuration directory
> --------------------------------------------------------------
>
> Key: YARN-5428
> URL: https://issues.apache.org/jira/browse/YARN-5428
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: YARN-5428.001.patch, YARN-5428.002.patch
>
>
> The docker client allows for specifying a configuration directory that
> contains the docker client's configuration. It is common to store "docker
> login" credentials in this config, to avoid the need to docker login on each
> cluster member.
> By default the docker client config is $HOME/.docker/config.json on Linux.
> However, this does not work with the current container executor user
> switching and it may also be desirable to centralize this configuration
> beyond the single user's home directory.
> Note that the command line arg is for the configuration directory NOT the
> configuration file.
> This change will be needed to allow YARN to automatically pull images at
> localization time or within container executor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
