[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396008#comment-15396008 ]
Yufei Gu edited comment on YARN-5137 at 7/27/16 5:19 PM: --------------------------------------------------------- Hi [~vvasudev], thanks for the review. Since {{conf}} in class {{TestLinuxContainerExecutorWithMocks}} is changed to {{YarnConfiguration}} instead of {{Configuration}}, it adds one item(local dir) into {{result}}. So it is 19 instead of 18 now. I changed {{conf}} to an instance {{YarnConfiguration}} since the class {{TestLinuxContainerExecutorWithMocks}} has an unstable assumption that it won't load any yarn configuration files, e.g., yarn-default.xml and yarn-site.xml. was (Author: yufeigu): Hi [~vvasudev], thanks for the review. Since {{conf}} in class {{TestLinuxContainerExecutorWithMocks}} is changed to {{YarnConfiguration}} instead of {{Configuration}}, it adds one item(local dir) into {{result}}. I changed {{conf}} to an instance {{YarnConfiguration}} since the class {{TestLinuxContainerExecutorWithMocks}} has an unstable assumption that it won't load any yarn configuration files, e.g., yarn-default.xml and yarn-site.xml. > Make DiskChecker pluggable in NodeManager > ----------------------------------------- > > Key: YARN-5137 > URL: https://issues.apache.org/jira/browse/YARN-5137 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Reporter: Ray Chiang > Assignee: Yufei Gu > Labels: supportability > Attachments: YARN-5137.001.patch, YARN-5137.002.patch, > YARN-5137.003.patch, YARN-5137.004.patch, YARN-5137.005.patch > > > It would be nice to have the option for a DiskChecker that has more > sophisticated checking capabilities. In order to do this, we would first > need DiskChecker to be pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org