[ 
https://issues.apache.org/jira/browse/YARN-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397858#comment-15397858
 ] 

Rohith Sharma K S commented on YARN-5436:
-----------------------------------------

Thanks for the clarification, especially *race can still happen without 
invoking dispatcher.serviceStop()* is main reason for test failures. This would 
solve YARN test failures also. 

+1 LGTM

> Race in AsyncDispatcher can cause random test failures in Tez(probably YARN 
> also )
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-5436
>                 URL: https://issues.apache.org/jira/browse/YARN-5436
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhiyuan Yang
>            Assignee: Zhiyuan Yang
>         Attachments: YARN-5436.1.patch, YARN-5436.2.patch, YARN-5436.3.patch, 
> YARN-5436.4.patch
>
>
> In YARN-2264, a race in DrainDispatcher was fixed. Unfortunately, it also 
> exists in AsyncDispatcher (this was found and ignored in YARN-3878 but never 
> documented...). In YARN-2991, another DrainDispatcher bug was fixed by 
> letting DrainDispatcher reuse some AsyncDispatcher method because 
> AsyncDispatcher doesn't have such issue. However, this shadows YARN-2264, and 
> now similar race reappears in Tez unit tests (probably also YARN unit tests 
> also).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to