[ https://issues.apache.org/jira/browse/YARN-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398122#comment-15398122 ]
Subru Krishnan commented on YARN-5327: -------------------------------------- Thanks [~ajsangeetha] for the patch. It mostly looks good, a few minor comments: * We need to add more meat to the Javadocs for {{ReservationDefinition::get/setPeriodicity}} like how we distinguish periodic/non-periodic, implicit priority in the event of replanning, consistency of allocation, good till cancelled aspect etc. * Can you add an explicit default value for *period* in {{yarn_protos.proto}}. * Maybe it makes sense to add *period* to {{ReservationDefinitionPBImpl::toString}}. > API changes required to support recurring reservations in the YARN > ReservationSystem > ------------------------------------------------------------------------------------ > > Key: YARN-5327 > URL: https://issues.apache.org/jira/browse/YARN-5327 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Subru Krishnan > Assignee: Sangeetha Abdu Jyothi > Attachments: YARN-5327.001.patch > > > YARN-5326 proposes adding native support for recurring reservations in the > YARN ReservationSystem. This JIRA is a sub-task to track the changes needed > in ApplicationClientProtocol to accomplish it. Please refer to the design doc > in the parent JIRA for details. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org