[
https://issues.apache.org/jira/browse/YARN-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431764#comment-15431764
]
Subru Krishnan edited comment on YARN-5327 at 8/22/16 11:07 PM:
----------------------------------------------------------------
Thanks [~ajsangeetha] for addressing the feedback. I have a few comments on the
latest patch (4):
* Can you rename {{period}} and associated getter/setters to
{{recurrenceExpression}}.
* Use *Long.parseLong* in {{ReservationInputValidator}}. Also you need to log
and throw exception on validation failure.
* You need to add corresponding tests (both positive and negative) for
{{ReservationInputValidator}}.
* Please address [~seanpo03]'s comment on updating REST APIs also.
was (Author: subru):
Thanks [~ajsangeetha] for addressing the feedback. I have a few comments on the
latest patch (4):
* Can you rename {{period}} and associated getter/setters to
{{recurrenceExpression}}.
* Use *Long.parseLong* in {{ReservationInputValidator}}.
* You need to add corresponding tests (both positive and negative) for
{{ReservationInputValidator}}.
* Please address [~seanpo03]'s comment on updating REST APIs also.
> API changes required to support recurring reservations in the YARN
> ReservationSystem
> ------------------------------------------------------------------------------------
>
> Key: YARN-5327
> URL: https://issues.apache.org/jira/browse/YARN-5327
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Subru Krishnan
> Assignee: Sangeetha Abdu Jyothi
> Attachments: YARN-5327.001.patch, YARN-5327.002.patch,
> YARN-5327.003.patch, YARN-5327.004.patch
>
>
> YARN-5326 proposes adding native support for recurring reservations in the
> YARN ReservationSystem. This JIRA is a sub-task to track the changes needed
> in ApplicationClientProtocol to accomplish it. Please refer to the design doc
> in the parent JIRA for details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
