[
https://issues.apache.org/jira/browse/YARN-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436288#comment-15436288
]
Karthik Kambatla commented on YARN-4805:
----------------------------------------
Good points, [~asuresh], [~subru].
Thinking more about this, I see two different cases we want to address here:
# Some tests that use MockRM/RM, which might not be scheduler dependent at all,
used to fail when run against FairScheduler because FairScheduler expects to be
configured with an allocations file. Initially, we created the
ParameterizedTests to make sure these tests don't fail with FairScheduler. In
hind sight, it likely would have sufficed to automatically create this
allocations file it did not exist.
# There are scheduler dependent tests that validate that both schedulers meet
the requirement - feature improvement / bug fix. Ideally, those tests need to
be Parameterized and run against all schedulers.
I am okay with reverting this, and instead updating FairScheduler to create the
allocations file. We could shrink the number of tests that extend
ParameterizedTests to only those that are scheduler dependent.
> Don't go through all schedulers in ParameterizedTestBase
> --------------------------------------------------------
>
> Key: YARN-4805
> URL: https://issues.apache.org/jira/browse/YARN-4805
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Fix For: 2.9.0
>
> Attachments: yarn-4805-1.patch
>
>
> ParameterizedSchedulerTestBase was created to make sure tests that were
> written with CapacityScheduler in mind don't fail when run against
> FairScheduler. Before this was introduced, tests would fail because
> FairScheduler requires an allocation file.
> However, the tests that extend it take about 10 minutes per scheduler. So,
> instead of running against both schedulers, we could setup the scheduler
> appropriately so the tests pass against both schedulers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
