[ https://issues.apache.org/jira/browse/YARN-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437460#comment-15437460 ]
Sean Po edited comment on YARN-5560 at 8/25/16 6:59 PM: -------------------------------------------------------- First patch removes occurrences of catch blocks that only invoke Assert.fail in TestYarnClient. was (Author: seanpo03): First patch removes occurrences of catch blocks that only invoke Assert.fail. > Clean up bad exception catching practices in TestYarnClient > ----------------------------------------------------------- > > Key: YARN-5560 > URL: https://issues.apache.org/jira/browse/YARN-5560 > Project: Hadoop YARN > Issue Type: Test > Reporter: Sean Po > Assignee: Sean Po > Attachments: YARN-5560.v1.patch > > > In TestYarnClient, tests commonly wrap methods that throw exceptions in a try > catch statement similar to the following: > {code} > try { > client.submitApplication(context); > } catch (Exception e) { > Assert.fail("Exception is not expected."); > } > {code} > This hides useful error messages, and surfaces less helpful ones. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org