[
https://issues.apache.org/jira/browse/YARN-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437846#comment-15437846
]
Daniel Templeton commented on YARN-4911:
----------------------------------------
Thanks for the patch [~rchiang]. Couple of comments.
First, can you please add a test to {{TestFairScheduler}} to test the behavior
you just changed?
Second, if you'll forgive the nit-picking, let's talk about your error message.
:)
bq. Unable to match app <appId> to a queue placement policy. Check with an
administrator to make sure submitting to a valid queue and/or check that the
queue placement policies have the create property set to true.
I think there's a word or two missing between "sure" and "submitting." I'd
also like to be a little more specific, like:
bq. Unable to match app <appId> to a queue placement policy, and no valid
terminal queue placement rule is configured. Please contact an administrator
to confirm that the fair scheduler configuration contains a valid terminal
queue placement rule.
I'd also log that same thing, or maybe something with a bit more technical
detail, as an ERROR or WARN.
> Bad placement policy in FairScheduler causes the RM to crash
> ------------------------------------------------------------
>
> Key: YARN-4911
> URL: https://issues.apache.org/jira/browse/YARN-4911
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Labels: supportability
> Attachments: YARN-4911.001.patch, YARN-4911.002.patch
>
>
> When you have a fair-scheduler.xml with the rule:
> <queuePlacementPolicy>
> <rule name="default" queue="okay1" create="false" />
> </queuePlacementPolicy>
> and the queue okay1 doesn't exist, the following exception occurs in the RM:
> 2016-04-01 16:56:33,383 FATAL
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: Error in
> handling event type APP_ADDED to the scheduler
> java.lang.IllegalStateException: Should have applied a rule before reaching
> here
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueuePlacementPolicy.assignAppToQueue(QueuePlacementPolicy.java:173)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.assignToQueue(FairScheduler.java:728)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.addApplication(FairScheduler.java:634)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.handle(FairScheduler.java:1224)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.handle(FairScheduler.java:112)
> at
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$SchedulerEventDispatcher$EventProcessor.run(ResourceManager.java:691)
> at java.lang.Thread.run(Thread.java:745)
> which causes the RM to crash.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
