[ 
https://issues.apache.org/jira/browse/YARN-5503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439349#comment-15439349
 ] 

Sunil G commented on YARN-5503:
-------------------------------

As discussed, ASF warnings are not related to the patch. Hence its fine. Also 
local test with rat plugin too came fine.

Still as discussed with Varun, could you please split patch so that .gitignore 
changes can be done separately as it touching all unit test cases from base 
folder and those are failing. Thoughts?

> [YARN-3368] Add missing hidden files in webapp folder
> -----------------------------------------------------
>
>                 Key: YARN-5503
>                 URL: https://issues.apache.org/jira/browse/YARN-5503
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: YARN-5503-YARN-3368-0001.patch, 
> YARN-5503-YARN-3368-0002.patch, YARN-5503-YARN-3368-0003.patch, 
> YARN-5503-YARN-3368-0004.patch, YARN-5503-YARN-3368.0005.patch
>
>
> - Feel it might be good to have a readme file with the basic instructions.
> - Just noticed that the hidden files that must be present in the base 
> directory of ember app, are missing. Most of them are used for configuration, 
> and when missing the default vakues would be used by ember.
> -- They include - .bowerrc, .editorconfig, .ember-cli, .gitignore, .jshintrc, 
> .travis.yml, .watchmanconfig



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to