[ https://issues.apache.org/jira/browse/YARN-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Po updated YARN-5560: -------------------------- Attachment: YARN-5560.v3.patch You're welcome [~jlowe], thanks for reviewing! V3 of the patch addresses your previous comment. > Clean up bad exception catching practices in TestYarnClient > ----------------------------------------------------------- > > Key: YARN-5560 > URL: https://issues.apache.org/jira/browse/YARN-5560 > Project: Hadoop YARN > Issue Type: Test > Reporter: Sean Po > Assignee: Sean Po > Attachments: YARN-5560.v1.patch, YARN-5560.v2.patch, > YARN-5560.v3.patch > > > In TestYarnClient, tests commonly wrap methods that throw exceptions in a try > catch statement similar to the following: > {code} > try { > client.submitApplication(context); > } catch (Exception e) { > Assert.fail("Exception is not expected."); > } > {code} > This hides useful error messages, and surfaces less helpful ones. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org